Skip to content

Extend const_convert with const {FormResidual, Try} for ControlFlow. #102144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 23, 2022
Merged

Extend const_convert with const {FormResidual, Try} for ControlFlow. #102144

merged 1 commit into from
Sep 23, 2022

Conversation

onestacked
Copy link
Contributor

Very small change so I just used the existing const_convert feature flag. #88674
Newly const API:

impl<B, C> const ops::Try for ControlFlow<B, C>;
impl<B, C> const ops::FromResidual for ControlFlow<B, C>;

@usbalbin I hope it is ok that I added to your feature.

@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Sep 22, 2022
@rustbot
Copy link
Collaborator

rustbot commented Sep 22, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rust-highfive
Copy link
Contributor

r? @scottmcm

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 22, 2022
@onestacked
Copy link
Contributor Author

@rustbot label +T-libs-api -T-libs

@rustbot rustbot added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Sep 22, 2022
@scottmcm
Copy link
Member

Result and Option both have this, so adding it to ControlFlow too seems perfectly reasonable for nightly.

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Sep 22, 2022

📌 Commit 5a5138d has been approved by scottmcm

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 22, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Sep 22, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 23, 2022
@bors
Auto merge of rust-lang#102150 - matthiaskrgr:rollup-6xmd8f3, r=matth…
bc4d574 
…iaskrgr

Rollup of 10 pull requests

Successful merges:

 - rust-lang#102113 (OpTy: fix a method taking self rather than &self)
 - rust-lang#102118 (rustdoc: clean up line numbers on code examples)
 - rust-lang#102123 (Add note to clippy::non_expressive_names doc)
 - rust-lang#102125 (rustdoc: remove no-op CSS `.content .item-info { position: relative }`)
 - rust-lang#102127 (Use appropriate variable names)
 - rust-lang#102128 (Const unification is already infallible, remove the error handling logic)
 - rust-lang#102133 (Use valtrees for comparison)
 - rust-lang#102135 (Improve some AllTypes fields name)
 - rust-lang#102144 (Extend const_convert with const {FormResidual, Try} for ControlFlow.)
 - rust-lang#102147 (rustdoc: remove no-op CSS `.location:empty { border: none }`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 2337063 into rust-lang:master Sep 23, 2022
@rustbot rustbot added this to the 1.66.0 milestone Sep 23, 2022
@onestacked onestacked deleted the const_convert_control_flow branch September 23, 2022 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@scottmcm scottmcm

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.66.0
Development

Successfully merging this pull request may close these issues.
5 participants
@onestacked @rustbot @rust-highfive @scottmcm @bors